Forráskód Böngészése

Fix coverage on ScoreBoard

Kirk Trombley 4 éve
szülő
commit
e5e0ecc498

+ 1 - 2
client/src/components/screens/GameSummary/ScoreBoard/ScoreBoard.jsx

@@ -21,8 +21,7 @@ export const PlayerScoreTile = ({ name, guesses, totalScore, winner }) => (
     <div className={styles.scores}>
       {Object.entries(guesses)
         .map(([k, v]) => [parseInt(k, 10), v])
-        // eslint-disable-next-line no-nested-ternary
-        .sort(([k1], [k2]) => (k1 < k2 ? -1 : k1 > k2 ? 1 : 0))
+        .sort(([k1], [k2]) => (k1 < k2 ? -1 : 1))
         .map(([num, { score, country }]) =>
           score !== undefined ? (
             <div className={styles.round} key={num}>

+ 4 - 3
client/src/tests/Scoreboard.test.js

@@ -74,9 +74,10 @@ describe("ScoreBoard", () => {
         <PlayerScoreTile
           name="Name"
           guesses={{
-            3: { score: 20, country: "test-country" },
-            1: { score: 50, country: "test-country" },
-            2: { score: 150, country: "test-country" },
+            // using these weird keys to force other branch of sort
+            "03": { score: 20, country: "test-country" },
+            "02": { score: 150, country: "test-country" },
+            "01": { score: 50, country: "test-country" },
           }}
           totalScore={220}
           winner