Переглянути джерело

Doing some quick cleanup to the PlayerScore display

Kirk Trombley 5 роки тому
батько
коміт
5e3985892c

+ 7 - 5
client/src/components/screens/PlayerScores/PlayerScoreTile.jsx

@@ -35,11 +35,13 @@ export default ({ name, guesses, totalScore }) => (
     <Name>{name}</Name>
     <TotalScore>Score: {totalScore}</TotalScore>
     <List>
-      <Score>{guesses["1"] && guesses["1"].score}</Score>
-      <Score>{guesses["2"] && guesses["2"].score}</Score>
-      <Score>{guesses["3"] && guesses["3"].score}</Score>
-      <Score>{guesses["4"] && guesses["4"].score}</Score>
-      <Score>{guesses["5"] && guesses["5"].score}</Score>
+      {
+        ["1", "2", "3", "4", "5"]
+          .map(key => {
+            const score = guesses[key]?.score
+            return score ? <Score key={key}>{score}</Score> : null
+          })
+      }
     </List>
   </Tile>
 );

+ 1 - 1
client/src/components/screens/PlayerScores/PlayerScores.jsx

@@ -45,7 +45,7 @@ export default ({ gameId, onReturnToStart }) => {
           scores
             .filter(({ currentRound }) => currentRound === null)
             .sort((p1, p2) => p1.totalScore > p2.totalScore ? -1 : (p1.totalScore < p2.totalScore ? 1 : 0))
-            .map(({ name, guesses, totalScore }) => <PlayerScoreTile key={name} {...{ name, guesses, totalScore }} />)
+            .map((data) => <PlayerScoreTile key={data.name} {...data} />)
         }
       </ScoreBoard>
       <Label>This page can be directly linked with:</Label>